Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] <rh-accordion> demo seems to hide content when JS doesn't load #2059

Open
markcaron opened this issue Nov 20, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@markcaron
Copy link
Collaborator

Describe the bug

The demo for <rh-accordion> seems to hide the content of the accordion panels when JS doesn't load.

IMO, accordion should degrade gracefully—showing content when JS fails.

Screenshots

image image

Steps to reproduce

  1. Go to rh-accordion demo
  2. Disable JS
  3. Refresh and see content is hidden and inaccessible

Expected behaviour

Failing open

Element HTML

No response

Operating System (OS)

iOS

Browser

Chrome

Additional browser or assistive technology info

No response

@markcaron markcaron added the bug Something isn't working label Nov 20, 2024
@bennypowers
Copy link
Member

accordion is SSRable, we could experiment with replacing the <button>/<span> combo in the shadow root with <details><summary> WDYT @markcaron ? Perhaps even better, we might compose in the new rh-disclosure and get all that for free, with a few style changes. WDYT @adamjohnson ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants