Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] <rh-tile> border accent #1718

Closed
markcaron opened this issue Jul 16, 2024 · 1 comment
Closed

[feat] <rh-tile> border accent #1718

markcaron opened this issue Jul 16, 2024 · 1 comment
Labels
feature New feature or request

Comments

@markcaron
Copy link
Collaborator

Description

There are no shadow parts for <rh-tile>, and we will need one to accommodate some custom styles, like having a red border top.

Suggested solution

Add a container shadow part

Screenshots

No response

Example API

rh-tile::part(container) {
  border-top: var(--rh-border-width-lg, 3px) solid var(--rh-color-accent-brand-on-light, #ee0000);
}

Additional context

No response

@markcaron markcaron added the feature New feature or request label Jul 16, 2024
@bennypowers bennypowers changed the title [feat] We need at least a container shadow part for <rh-tile> [feat] <rh-tile> border accent Jul 17, 2024
@markcaron
Copy link
Collaborator Author

markcaron commented Jul 17, 2024

Adding for posterity and context:

I created this ticket so that we could handle some customized components in mockups/designs that we've seen come up over the last year, including the Get Started Dashboard's 1, 2, 3 "tiles":

image

The original thought I proposed about adding a shadow part, like outer or container, was to make the API consistent with <rh-card> assuming the preference would be to make these a simple patterned CSS customization rather than adding a defined variant.

After discussing with the team, we're going to expose a couple new custom props to handle the border-top customization in lieu of adding a new variant (for now, at least) or the shadow part "sledgehammer" approach.

Closing this in favor of #1719

@github-project-automation github-project-automation bot moved this from Backlog to Done ☑️ in Red Hat Design System Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done ☑️
Development

No branches or pull requests

1 participant