Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] <rh-card> docs: guidelines page #1662

Closed
marionnegp opened this issue Jun 25, 2024 · 1 comment · Fixed by #1188
Closed

[bug] <rh-card> docs: guidelines page #1662

marionnegp opened this issue Jun 25, 2024 · 1 comment · Fixed by #1188
Labels
bug Something isn't working docs Improvements or additions to documentation

Comments

@marionnegp
Copy link
Collaborator

Describe the bug

All of the card variants look the same under the Guidelines subpage of the Card element docs.
Screenshot 2024-06-25 at 12 15 56 PM

Which Component?

rh-card

Steps to reproduce

Visit the Variants section.

Expected behaviour

Variants should look more like the variant demos: https://ux.redhat.com/elements/card/demo/variants/#. We might also want to add some lightdom CSS to make those card headings' font size 24px (--rh-font-size-heading-sm)..

Screenshots

No response

Element HTML

No response

Operating System (OS)

macOS

Browser

No response

More browser information

No response

Additional Info

No response

@marionnegp marionnegp added the bug Something isn't working label Jun 25, 2024
@marionnegp marionnegp changed the title [bug] <rh-card> guidelines page [bug] <rh-card> docs: guidelines page Jun 25, 2024
@bennypowers
Copy link
Member

#1188 will close this

@marionnegp marionnegp added the docs Improvements or additions to documentation label Jun 25, 2024
@marionnegp marionnegp linked a pull request Jun 26, 2024 that will close this issue
@markcaron markcaron changed the title [bug] <rh-card> docs: guidelines page [bug] <rh-card> docs: guidelines page Jun 27, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done ☑️ in Red Hat Design System Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation
Projects
Status: Done ☑️
Development

Successfully merging a pull request may close this issue.

2 participants