Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] <rh-pagination>: element updates and new pattern #1457

Closed
marionnegp opened this issue Jan 23, 2024 · 5 comments · Fixed by #1587
Closed

[feat] <rh-pagination>: element updates and new pattern #1457

marionnegp opened this issue Jan 23, 2024 · 5 comments · Fixed by #1587
Assignees
Labels
feature New feature or request

Comments

@marionnegp
Copy link
Collaborator

marionnegp commented Jan 23, 2024

Description

Feedback on current element:

  • The current design looks heavy and too large on some pages, like Portal and Catalog.
  • There should be an option for stacking the compact pagination with the "Go to page" input like in the screenshot below.
    Screenshot 2024-01-23 at 1 48 33 PM
  • There's also a need for the dropdown menu with options for changing the number of results per page. This is available in PatternFly.
Screenshot 2024-01-23 at 1 46 25 PM

Suggested solution

I'm proposing adjustments to the light theme colors, size adjustments, a compact variant, and a pagination + item per page selector. (Figma link)

Example API

No response

Additional context

No response

@marionnegp marionnegp added the feature New feature or request label Jan 23, 2024
@marionnegp
Copy link
Collaborator Author

@hellogreg @markcaron, should this go in Chansey or Charmander?

@markcaron markcaron changed the title [feat] <rh-pagination>: element updates and new pattern [feat] <rh-pagination>: element updates and new pattern Jan 24, 2024
@hellogreg hellogreg added this to the 2024/Q1 — Chansey release milestone Jan 25, 2024
@coreyvickery
Copy link
Collaborator

coreyvickery commented Apr 26, 2024

@markcaron @hellogreg I would also like to get this done in Charmander.

@zeroedin Could we also fold in 1393 here too?

@adamjohnson
Copy link
Collaborator

Looks like the color adjustments to the light theme were handled in #1393 (#1552).

I will look into implementing the open, size (small), and compact variants.

Should "Pagination + items per page selector" use <pf-dropdown> or wait for <rh-dropdown>?

@coreyvickery
Copy link
Collaborator

@adamjohnson Can we convert pf-dropdown (PF5) to rh-dropdown quickly? I think the styles are exactly the same.

cc @markcaron @zeroedin

@adamjohnson
Copy link
Collaborator

I'm going to defer to @markcaron and @zeroedin's experience on this question from Corey:

Can we convert pf-dropdown (PF5) to rh-dropdown quickly? I think the styles are exactly the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done ☑️
Development

Successfully merging a pull request may close this issue.

6 participants