Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][feat] <rh-logo-wall> #1382

Closed
2 tasks
marionnegp opened this issue Dec 13, 2023 · 8 comments
Closed
2 tasks

[docs][feat] <rh-logo-wall> #1382

marionnegp opened this issue Dec 13, 2023 · 8 comments
Assignees
Labels
for dev Ready for development new component New component to be created red hack day Good issue for Red Hack Day

Comments

@marionnegp
Copy link
Collaborator

marionnegp commented Dec 13, 2023

Description

This component would display a grid of logos that can be clickable.

Acceptance Criteria

  • Design done
  • Development done

Image

No response

Link to design doc

Figma file

Other resources

Drive with images and docs

@marionnegp marionnegp added needs info Further information is requested for design Design work is requested needs discovery Needs discovery new component New component to be created needs prioritization This issue needs prioritization labels Dec 13, 2023
@marionnegp
Copy link
Collaborator Author

A few examples:

Screenshot 2023-12-13 at 4 15 18 PM
(on redhat.com)

Screenshot 2023-12-13 at 4 15 57 PM
Screenshot 2023-12-13 at 4 16 07 PM
(on the OpenShift product page)

@diwanshi
Copy link
Collaborator

diwanshi commented Jan 9, 2024

I'd like to work on this one, once its ready for the dev as I've build something similar in cp-elements

@markcaron
Copy link
Collaborator

@diwanshi @marionnegp, I wonder if this is more of a Pattern than a component/Element. Not sure we'd need to use Web Components to do something that's simple CSS and an <a> around an image or SVG.

@hellogreg hellogreg changed the title [feat] <rh-logo-wall> [feat] <rh-logo-wall> Feb 8, 2024
@marionnegp
Copy link
Collaborator Author

marionnegp commented Mar 7, 2024

Additional examples on Partners machine learning page and OpenShift AI page

  • Need to determine number of logos per row, amount of spacing in between, and maybe a max height or width
  • This should be a pattern, not a component

@markcaron
Copy link
Collaborator

markcaron commented Mar 19, 2024

@diwanshi, @gradymcgee will work on this with @marionnegp and once the design is ready (and in Figma), they can hand it off to development.

One thing left to discuss on the engineering side is where Patterns will official live in the repo. Currently, they're under /docs/patterns, but perhaps they should be at the root (parallel to /elements)? I'm thinking we'd want patterns and their CSS packaged, right?

CC: @bennypowers @zeroedin @nikkimk

@bennypowers
Copy link
Member

@markcaron @nikkimk when our heads are cleared of pfe 3 release, we should just go ahead and publish v0.x of pattern manifest, maybe take this as a first example

@markcaron markcaron moved this from Todo to In Progress 🟢 in Red Hat Design System Apr 29, 2024
@diwanshi diwanshi added the red hack day Good issue for Red Hack Day label Jun 10, 2024
@diwanshi diwanshi self-assigned this Jun 11, 2024
@markcaron markcaron added for dev Ready for development and removed needs info Further information is requested needs discovery Needs discovery needs prioritization This issue needs prioritization for design Design work is requested labels Jun 13, 2024
@markcaron
Copy link
Collaborator

@gradymcgee when you get the element mockup and documentation mockups done, can you provide those links at the top in the main description?

@gradymcgee
Copy link
Collaborator

I think I'm done designing the logo wall. I've added links to the Figma file and the Google Drive containing docs and images.

@markcaron markcaron changed the title [feat] <rh-logo-wall> [docs][feat] <rh-logo-wall> Aug 14, 2024
@github-project-automation github-project-automation bot moved this from Review 🔍 to Done ☑️ in Red Hat Design System Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for dev Ready for development new component New component to be created red hack day Good issue for Red Hack Day
Projects
Status: Done ☑️
Development

No branches or pull requests

6 participants