Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] <rh-card> slotted title pattern padding not aligned #1209

Closed
brianferry opened this issue Sep 5, 2023 · 2 comments
Closed

[bug] <rh-card> slotted title pattern padding not aligned #1209

brianferry opened this issue Sep 5, 2023 · 2 comments
Labels
bug Something isn't working needs discovery Needs discovery needs refinement This issue needs to be refined needs revisiting Outdated issues worth revisiting in the future

Comments

@brianferry
Copy link
Collaborator

Describe the bug

Link

In the "Slotted Title" pattern for card, the padding for the Header and the Body are not aligned. The heading has a padding-inline of 24px and the body has a padding-inline of 32px. Put more simply, the heading is using --rh-space-xl and the body is using --rh-space-2xl.

Which Component?

rh-card

Steps to reproduce

  1. Go to https://deploy-preview-1200--red-hat-design-system.netlify.app/patterns/card/#sample---slotted-title
  2. Inspect the Header for the "Slotted Title" pattern
  3. Confirm the padding-inline is 24px
  4. Inspect the Body of the card
  5. Confirm the padding-inline is 32px.

Expected behaviour

The heading and the body should be inline the same amount

Screenshots

No response

Element HTML

No response

Operating System (OS)

macOS

Browser

No response

More browser information

No response

Additional Info

No response

@brianferry brianferry added the bug Something isn't working label Sep 5, 2023
@marionnegp
Copy link
Collaborator

marionnegp commented Sep 6, 2023

@brianferry, the padding in the title bar (16px) looks correct. I was wondering if we wanted to allow slotted titles that look like this:
Screenshot 2023-09-06 at 9 47 47 AM
or if text in the header should always be styled like it is in the title bar pattern:
Screenshot 2023-09-06 at 9 47 53 AM

The headline, sm style would typically be in the body, where it would be closer to any other body copy, so the slotted title makes the card spacing look funky. Maybe I'm misunderstanding the examples on the Card pattern page?

cc: @coreyvickery

@markcaron markcaron added needs discovery Needs discovery needs refinement This issue needs to be refined labels Sep 15, 2023
@markcaron markcaron moved this from Todo to Backlog in Red Hat Design System Sep 15, 2023
@markcaron markcaron added the needs revisiting Outdated issues worth revisiting in the future label Feb 7, 2024
@hellogreg hellogreg changed the title [bug] <rh-card> slotted title pattern padding not aligned [bug] <rh-card> slotted title pattern padding not aligned Feb 8, 2024
@markcaron
Copy link
Collaborator

Fixed by #1380

@github-project-automation github-project-automation bot moved this from Backlog to Done ☑️ in Red Hat Design System Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs discovery Needs discovery needs refinement This issue needs to be refined needs revisiting Outdated issues worth revisiting in the future
Projects
Status: Done ☑️
Development

No branches or pull requests

3 participants