Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Firefox: Date picker in model input is broken #259

Open
macfarlandian opened this issue Apr 29, 2020 · 7 comments
Open

Firefox: Date picker in model input is broken #259

macfarlandian opened this issue Apr 29, 2020 · 7 comments

Comments

@macfarlandian
Copy link
Collaborator

macfarlandian commented Apr 29, 2020

Describe the bug
The date picker for Planned Releases fails to populate the date field. (The field can still be updated by typing in a date manually.)

To Reproduce
Steps to reproduce the behavior:

  1. Go to the facility page for any facility
  2. Click on an empty date field for planned reductions under "Mitigation effors"
  3. Click on a date in the calendar popover
  4. See error: date field remains blank
  5. (alternatively: do the same for an already populated date field and observe that the field value does not change)

Expected behavior
Date field should be populated with the selected date

Screenshots
Screenshots revealing sensitive information must not be shared. If a screenshot is helpful in diagnosing and resolving the bug, please send this directly to a contact on the Recidiviz team.

Desktop (please complete the following information):

  • OS [e.g. Windows 10]: macOS Catalina
  • Browser [e.g. chrome, edge]: Firefox
  • Version [e.g. 22]: latest

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]:
  • OS: [e.g. iOS8.1]:
  • Browser [e.g. stock browser, safari]:
  • Version [e.g. 22]:

Additional context
Bug is seen on latest master development builds but does not currently occur in prod

Note:
master: https://recidiviz-covid19-dashboard.now.sh/
prod: https://model.recidiviz.org/

@macfarlandian
Copy link
Collaborator Author

latest Chrome browser does not exhibit this bug

@szhu
Copy link
Contributor

szhu commented Apr 29, 2020

Okay, I just tested and can confirm as well. Works on Chrome but not Firefox.

Note that in Firefox, nothing is logged to the console when the date is selected, so this will require some debugging…

@macfarlandian
Copy link
Collaborator Author

makes me wonder whether it happens in IE11 also @szhu ?

@jessex jessex changed the title Date picker in model input is broken Firefox: Date picker in model input is broken Apr 29, 2020
@szhu
Copy link
Contributor

szhu commented Apr 29, 2020

It actually works on IE11 -- just checked!

@szhu
Copy link
Contributor

szhu commented Apr 29, 2020

@jessex what percent of our users are using Firefox? Want to know how urgent this is

@jessex
Copy link
Member

jessex commented Apr 30, 2020

Firefox has about 4% of overall usage right now, but the browser stats skew towards Chrome (even with the in-place filter to take out localhost and now.sh traffic) owing to all of the development and internal activity happening in Chrome. I would guess it's not significantly higher, though.

@glen0071 glen0071 self-assigned this May 20, 2020
@glen0071
Copy link
Contributor

I got a response from the react-date-picker maintainer, will try to wrap this up quickly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants