Fix filter and collection docs links #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashkarpetin
approved these changes
Apr 11, 2024
mehicalen
approved these changes
Apr 11, 2024
noon-dawg
approved these changes
Apr 11, 2024
2 tasks
justnero
reviewed
Apr 11, 2024
Comment on lines
9
to
-11
| schema: | ||
| type: array | ||
| items: | ||
| type: string |
There was a problem hiding this comment.
@mikerebilly could you explain me this change? I believe it's incorrect.
Please see specification for style: form + explode: false
There was a problem hiding this comment.
@justnero You're right seems like i'm wrong, maybe we can revert this specific part of the PR. https://swagger.io/specification/#style-values:~:text=200.B%3D150-,form,false,-color%3D cc @mehicalen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove old documentation about filters and expand, and link to new docs. Also fixed
sortdefinition and description.Links
Checklist