Add address-based and refactor AML confidence settings #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noon-dawg
reviewed
Nov 22, 2023
noon-dawg
reviewed
Nov 22, 2023
noon-dawg
reviewed
Nov 22, 2023
noon-dawg
reviewed
Nov 22, 2023
mikerebilly
force-pushed
the
add-address-aml-settings
branch
from
9b703a5
to
0b7899e
Compare
mikerebilly
force-pushed
the
add-address-aml-settings
branch
from
1c52e81
to
4fd3861
Compare
noon-dawg
reviewed
Nov 29, 2023
noon-dawg
reviewed
Nov 29, 2023
mikerebilly
changed the title
noon-dawg
reviewed
Nov 30, 2023
noon-dawg
reviewed
Nov 30, 2023
noon-dawg
reviewed
Nov 30, 2023
ashkarpetin
reviewed
Nov 30, 2023
ashkarpetin
previously approved these changes
Nov 30, 2023
noon-dawg
previously approved these changes
Nov 30, 2023
adamaltman
reviewed
Dec 1, 2023
Comment on lines
+17
to
+22
| matchingCountry: | ||
| $ref: ./AmlConfidence.yaml | ||
| mismatchingCountry: | ||
| $ref: ./AmlConfidence.yaml | ||
| noCountry: | ||
| $ref: ./AmlConfidence.yaml |
There was a problem hiding this comment.
I'm confused by these property names. How do you find the mismatch?
There was a problem hiding this comment.
@adamaltman Most of our records (from sources) populate the country fields with common names, not the ISO standard. So we first see how well a customer's country matches against the database among all other considerations, and then we run binary logic afterward to consider the country a match or not.
mikerebilly
dismissed stale reviews from noon-dawg and ashkarpetin
via
0ba4d1d
ashkarpetin
approved these changes
Dec 13, 2023
swilczynski
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add address and region-based AML confidence settings. Includes restructuring of the remaining confidence part of the API scheme. This will be accounted for and also after searching logs, it is currently only used by Rebillly's app.
The PHP SDK model(s) would need to be regenerated.
Links
Preview
Checklist