Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmet peer dependencies #169

Closed
jeff-matthews opened this issue Dec 19, 2016 · 10 comments
Closed

Unmet peer dependencies #169

jeff-matthews opened this issue Dec 19, 2016 · 10 comments

Comments

@jeff-matthews
Copy link

jeff-matthews commented Dec 19, 2016

The following unmet peer dependencies seem to be causing npm start errors after cloning the repo and running npm install:

Running npm install produces several errors.txt and prevents redoc from rendering swagger.yaml locally.

Manual installation works for istanbul and tslint only, but not the remaining dependencies.

ReDoc v1.6.2
node v6.9.2
Mac OS X v10.11.6

Chrome browser console log
localhost-1482178647617.txt

@RomanHotsiy
Copy link
Member

RomanHotsiy commented Dec 19, 2016

Seems to be an issue with awesome-typescript-loader

Will try to update deps and stick them to working versions

@RomanHotsiy
Copy link
Member

@jeff-matthews try now and let me know if it works for you.

Before try, remove and install all node_modules

@RomanHotsiy
Copy link
Member

seems it was the same as #168. The author of #168 confirms the issue has been fixed.

Closing this issue so far. Feel free to reopen if the issue is not resolved for you

@jeff-matthews
Copy link
Author

thanks @RomanGotsiy. I'm able to run npm start without errors and render swagger.yaml locally.

Interestingly, I'm still getting warnings about unmet peer dependencies on npm install, which may be a problem for continuous integration (CI) unless I can modify my CI build script to ignore the warnings.

@RomanHotsiy
Copy link
Member

These warnings are not critical. I will fix them in the future

@seanpk
Copy link

seanpk commented Feb 8, 2017

@RomanGotsiy - I'd like to see the peer dependency warnings fixed on npm install too.
How were you thinking to solve this?

I wish there were peer dependencies for development in the package.json spec :-)

@RomanHotsiy
Copy link
Member

@seanpk let me know what are the warnings you see and which npm version you use.

I have [email protected] and just did rm -rf node_modules && npm install and can't see any warnings.

@seanpk
Copy link

seanpk commented Feb 8, 2017

$ npm -v && npm i redoc
3.10.10
[email protected] /Users/sean/Development/canary/foo
├── UNMET PEER DEPENDENCY @angular/common@^2.4.5
├── UNMET PEER DEPENDENCY @angular/compiler@^2.4.5
├── UNMET PEER DEPENDENCY @angular/core@^2.4.5
├── UNMET PEER DEPENDENCY @angular/platform-browser@^2.4.5
├── UNMET PEER DEPENDENCY @angular/platform-browser-dynamic@^2.4.5
├── UNMET PEER DEPENDENCY @angular/platform-server@^2.4.5
├── UNMET PEER DEPENDENCY core-js@^2.4.1
├─┬ [email protected]
│ └── [email protected]  (git://github.com/julmot/mark.js.git#d4977c66c333275c4de665007ea7afae88286f0a)
├── UNMET PEER DEPENDENCY rxjs@^5.0.1
└── UNMET PEER DEPENDENCY zone.js@^0.7.2

npm WARN [email protected] requires a peer of @angular/common@^2.4.5 but none was installed.
npm WARN [email protected] requires a peer of @angular/compiler@^2.4.5 but none was installed.
npm WARN [email protected] requires a peer of @angular/core@^2.4.5 but none was installed.
npm WARN [email protected] requires a peer of @angular/platform-browser@^2.4.5 but none was installed.
npm WARN [email protected] requires a peer of @angular/platform-browser-dynamic@^2.4.5 but none was installed.
npm WARN [email protected] requires a peer of @angular/platform-server@^2.4.5 but none was installed.
npm WARN [email protected] requires a peer of core-js@^2.4.1 but none was installed.
npm WARN [email protected] requires a peer of rxjs@^5.0.1 but none was installed.
npm WARN [email protected] requires a peer of zone.js@^0.7.2 but none was installed.
$

@RomanHotsiy
Copy link
Member

hmm, its strange as these dependencies are listed both in devDependencies and peerDependencies in package.json: https://github.com/Rebilly/ReDoc/blob/master/package.json#L50-L56

I will investigate

@seanpk
Copy link

seanpk commented Feb 8, 2017

when I install the redoc package into my own project, doesn't npm install it in "production" mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants