Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply filtering to types when selecting a leaf node #526

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: apply filtering to types when selecting a leaf node #526

merged 1 commit into from
Jan 23, 2025

Conversation

RebeccaStevens
Copy link
Owner

fixes #524

@RebeccaStevens Graphite App
Copy link
Owner Author

RebeccaStevens commented Jan 23, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@RebeccaStevens RebeccaStevens mentioned this pull request Jan 23, 2025
Merged
@RebeccaStevens RebeccaStevens marked this pull request as ready for review January 23, 2025 02:04
@RebeccaStevens RebeccaStevens changed the base branch from 01-23-refactor_rename_tuplifyunion_to_uniontotuple to graphite-base/526 January 23, 2025 02:04
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (98400c3) to head (bdb5a74).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #526   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files           8        8           
  Lines         558      558           
  Branches      116      116           
=======================================
  Hits          551      551           
  Misses          7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RebeccaStevens RebeccaStevens force-pushed the 01-23-fix_apply_filtering_to_types_when_selecting_a_leaf_node branch from ad0ad2b to 79f002a Compare January 23, 2025 02:05
@RebeccaStevens RebeccaStevens changed the base branch from graphite-base/526 to main January 23, 2025 02:05
@RebeccaStevens RebeccaStevens force-pushed the 01-23-fix_apply_filtering_to_types_when_selecting_a_leaf_node branch from 79f002a to bdb5a74 Compare January 23, 2025 02:05
@RebeccaStevens RebeccaStevens merged commit 6d85163 into main Jan 23, 2025
13 checks passed
@RebeccaStevens RebeccaStevens deleted the 01-23-fix_apply_filtering_to_types_when_selecting_a_leaf_node branch January 23, 2025 02:09
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
@semantic-release-bot
chore(release): 7.1.4 [skip ci]
5855619 
## [7.1.4](v7.1.3...v7.1.4) (2025-01-23)

### Bug Fixes

* apply filtering to types when selecting a leaf node ([#526](#526)) ([6d85163](6d85163)), closes [#524](#524)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Released It's now live. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Released It's now live.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect type inference for a field that is not optional, but has type of a union with undefined
1 participant
@RebeccaStevens