Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of unaudited code in zksync-era #119

Open
edmundedgar opened this issue Jun 8, 2023 · 0 comments
Open

Fix use of unaudited code in zksync-era #119

edmundedgar opened this issue Jun 8, 2023 · 0 comments

Comments

@edmundedgar
Copy link
Contributor

We had to make a small change to support zksync-era which hasn't been audited (but should be fine) to replace the use of transfer which fails on zksync because it relies on hard-coded gas costs which don't apply on zk-sync.

Apparently zk-sync have a change in the pipeline that will make transfer work. If that ships we can redeploy with the standard version. We may need to do something to handle both versions in the UI if people are using it.

Alternatively, in the next version, replace the use of transfer and ship a version that works on all chains. We probably want to do this after Cancun as EIP-1153 makes reentrancy guards cheaper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant