Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

done is not a function #92

Closed
taylor1791 opened this issue Sep 4, 2016 · 3 comments
Closed

done is not a function #92

taylor1791 opened this issue Sep 4, 2016 · 3 comments

Comments

@taylor1791
Copy link

React native has a non-standard extension to Promise. It adds a done method that throws any uncaught errors. Unless I am mistaken, I don't believe react-native-mock adds this. Are there plans to do this?

@RealOrangeOne
Copy link
Owner

I did not know react-native did this, so no there arent any plans for this. Can you provide some examples of this, as i'm not exactly sure what it's use is.

@taylor1791
Copy link
Author

I discovered this in the AsyncStorage Example. More research shows that using done is no longer necessary after 0fa8d16 fixed !facebook/react-native/4045.

So, if people are on a recent version of react-native they can remove it without any harm. For this reason, I don't need it anyone. In theory, if someone is on a sufficiently old version of react-native, they may need this.

If you think this is something react-native-mock does not need, feel free to close the issue.

@RealOrangeOne
Copy link
Owner

Seeing as it's now been fixed. I think it's fine not to support it. Generally we only try to support the most recent version of react-native

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants