Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for "fromEvent" shows wrong/random results #6500

Closed
martinsik opened this issue Jun 30, 2021 · 2 comments · Fixed by #6952
Closed

Searching for "fromEvent" shows wrong/random results #6500

martinsik opened this issue Jun 30, 2021 · 2 comments · Fixed by #6952

Comments

@martinsik
Copy link
Contributor

Bug Report

Current Behavior
When I go to https://rxjs.dev/ and use the search field in the top right corner to search for "fromEvent" it's suggesting wrong/incomplete results.

rxjs-frome
rxjs-fromev
rxjs-fromeven
rxjs-fromevent

Expected behavior

When typing into the search field I should see smaller and smaller subset of search results probably ending with fromEvent and fromEventPattern.

@tmair
Copy link
Contributor

tmair commented Jul 7, 2021

I had a quick look at this issue and it seems that keyword generation for the search index is not working correctly.

In your case fromEvent is used in many Examples and somehow the content of the examples are included within the keywords of the document. Searching for click will also return many documents.

@martinsik
Copy link
Contributor Author

martinsik commented Apr 20, 2022

I was investigating this a little and there's something wrong with lunr.js I think. When I search for fromeven it searches for "titleWords:*fromeven* fromeven" which should find both fromEvent() and fromEventPattern(). When I try the same query "name:*Shepar* Shepard" at https://olivernn.github.io/moonwalkers/ it works as expected.

I created an issue in their repo as well olivernn/lunr.js#513.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants