Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minify version cause Arrray.from() failed under IE11 with es6-shim.js #3941

Closed
waitingsong opened this issue Jul 21, 2018 · 2 comments
Closed

minify version cause Arrray.from() failed under IE11 with es6-shim.js #3941

waitingsong opened this issue Jul 21, 2018 · 2 comments
Labels
bug Confirmed bug

Comments

@waitingsong
Copy link

waitingsong commented Jul 21, 2018 •
edited
Loading

Bug Report

Current Behavior
Array.from( <Set> ) return empty.
rxjs.umd.min.js version >=6
es6-shim.js v0.35.3

Reproduction

<!DOCTYPE html>
<html lang="zh-CN"><head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta name="renderer" content="webkit">
<title>rxjs test</title>
</head>
<body>
  <h>rxjs test</h>

  <script src="https://cdnjs.cloudflare.com/ajax/libs/es6-shim/0.35.3/es6-shim.js" ></script>
  <script src="https://cdnjs.cloudflare.com/ajax/libs/rxjs/6.2.2/rxjs.umd.min.js" ></script>

  <script>
  var st = new Set()
  st.add('foo')

  try {
    var arr = Array.from(st)
    console.log(arr)
    alert(arr)
  }
  catch(ex) {
    alert(ex)
  }
  </script>
</body>
</html>

Expected behavior
Should alert "foo"

Environment

  • Runtime: [windows7 64bit, IE v11]
  • RxJS version: all v6 minify version

Possible Solution

Additional context/Screenshots
No issue with un-compress verison, eg:

<script src="https://cdnjs.cloudflare.com/ajax/libs/rxjs/6.2.2/rxjs.umd.js" ></script>
@cartant cartant added the bug Confirmed bug label Jan 28, 2019
@cartant
Copy link
Collaborator

cartant commented Jan 28, 2019

The polyfills that are incorporated in the Closure-built minified bundle are responsible for this error being effected, but that's as far as I'm gonna take this because ... IE.

@cartant
Copy link
Collaborator

cartant commented Jan 30, 2019

Closing, as this should be resolved by #4487

@cartant cartant closed this as completed Jan 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Confirmed bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waitingsong @cartant