Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to get WebSocketSubject & WebSocketSubjectConfig type definitions #3457

Closed
Delagen opened this issue Mar 21, 2018 · 4 comments
Closed

How to get WebSocketSubject & WebSocketSubjectConfig type definitions #3457

Delagen opened this issue Mar 21, 2018 · 4 comments
Labels
bug Confirmed bug

Comments

@Delagen
Copy link
Contributor

Delagen commented Mar 21, 2018

RxJS version: 6.0.0-beta.1

Code to reproduce:
rxjs ^5

import {
	WebSocketSubject,
	WebSocketSubjectConfig
} from "rxjs/observable/dom/WebSocketSubject";

const subject:WebSocketSubject<T> = new WebSocketSubject<T>(...);

rxjs ^6

import {
       websocket,
	WebSocketSubject, ????????????????????? 
	WebSocketSubjectConfig ?????????????????????
} from "rxjs/websocket";

const subject:WebSocketSubject<T> = websocket<T>(...);

Expected behavior:
Provide compatible code

Actual behavior:
No way to get type checking without using internal types

Additional information:

@Delagen
Copy link
Contributor Author

Delagen commented Mar 21, 2018

Temporary imported from "rxjs/internal/observable/dom/WebSocketSubject", but I want to know official way to do it.

@benlesh
Copy link
Member

benlesh commented Apr 8, 2018

It's apparently an oversight in our exports. Thanks.

@Delagen
Copy link
Contributor Author

Delagen commented Apr 13, 2018

@benlesh I am not sure that correct, but opened PR

@benlesh benlesh closed this as completed Apr 14, 2018
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

2 participants