Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromEvent not removing event listener when bound using event options #3349

Closed
crisbeto opened this issue Feb 26, 2018 · 1 comment · Fixed by Xenira/Shashki#66
Closed

fromEvent not removing event listener when bound using event options #3349

crisbeto opened this issue Feb 26, 2018 · 1 comment · Fixed by Xenira/Shashki#66

Comments

@crisbeto
Copy link
Contributor

RxJS version:
5.5.6

Code to reproduce:

const subscription = fromEvent<KeyboardEvent>(document.body, 'keydown', true).subscribe(() => {});

// To check the bound keyboard listeners, use `getEventListeners(document.body).keydown` in the Chrome dev tools.

subscription.unsubscribe();

// Run `getEventListeners(document.body).keydown` again to check the amount of event listeners.

Expected behavior:
The keydown event should be removed.

Actual behavior:
The keydown event isn't being removed.

Additional information:
The issue only seems to happen when passing in the third argument to fromEvent. It passes the argument along to addEventListener correctly, however the same set of arguments have to be passed back to removeEventListener in order for the event to be removed when unsubscribing.

Related issue: angular/components#10143
Related PR: angular/components#10160

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant