Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation - skipLast - Real World Example #3094

Closed
KiltedCode opened this issue Nov 15, 2017 · 13 comments
Closed

Add Documentation - skipLast - Real World Example #3094

KiltedCode opened this issue Nov 15, 2017 · 13 comments

Comments

@KiltedCode
Copy link

Add a real world code example to the documentation to demonstrate how the operator can be used. Provide code that demonstrates what it can do but also a real world example of when you would use it.

@david-driscoll
Copy link
Member

@RhGeek Is there a specific reasoning you're spamming the repository with 3 issues per operator about documentaiton?

@KiltedCode
Copy link
Author

@david-driscoll it is a part of the docs initiative to add these for missing operators ReactiveX/rxjs-docs#4

@david-driscoll
Copy link
Member

Should that not go on the rxjs-docs repo?

@KiltedCode
Copy link
Author

The discussion / decision was to add them over here. There are some previously made, these were the last that were needed. Looping in @ladyleet for explanation.

@ladyleet
Copy link
Member

@RhGeek no, we made a decision to add all issues to the rxjs docs repo and it was already done - check the issues on the docs repo! Thx for your effort though. Ashwin did this awhile ago.

@KiltedCode
Copy link
Author

@ladyleet oh no. that was my misunderstanding. when i created the first 3 and linked them, we said everything looked good and then i created the first batch. I was finishing them up. my apologies and mess up. I'll clean this mess up then.

@ladyleet
Copy link
Member

@RhGeek no worries! It was awhile ago so someone proceeded on the issue so they could get going with the docs.

@rgbkrk
Copy link
Contributor

rgbkrk commented Nov 15, 2017

On a positive note, this made me realize that there was an rxjs-docs effort with a bunch of various folks since I only follow ReactiveX/rxjs (and sparingly at that).

@ladyleet
Copy link
Member

Hahaa love it! :)

@martinsik
Copy link
Contributor

@rgbkrk I didn't know about it either until I read your comment :(.

@KiltedCode
Copy link
Author

well, at least there is some positive to my goofing then @rgbkrk and @martinsik. Glad to raise awareness ;-)

@ladyleet
Copy link
Member

Happy about it too! We def welcome more contributors to the docs!

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants