Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip operator's type definition is incompatible with RxJS v4 #1208

Closed
tetsuharuohzeki opened this issue Jan 18, 2016 · 6 comments
Closed

zip operator's type definition is incompatible with RxJS v4 #1208

tetsuharuohzeki opened this issue Jan 18, 2016 · 6 comments
Labels
TS Issues and PRs related purely to TypeScript issues

Comments

@kwonoj
Copy link
Member

kwonoj commented Jan 18, 2016

@david-driscoll , as well as #1209 I assume this is related with your current effort of introducing n-number parameter signatures for some operators, is my understanding correct?

@david-driscoll
Copy link
Member

Yep, most of the work is done on the RxJS4 side, just need to migrate it over to RxJS5 without interuptions. Once #1086 lands, I was planning on adding more for zip, withLatestFrom, combineLatest (static) and more.

@david-driscoll
Copy link
Member

Based on one of my previous attempts at getting the typings working, I have the following (at the time generated file) that has pretty much all they typings we're looking for. It's a little outdated, but I'll be pulling from there to start.

https://github.com/david-driscoll/RxJS-1/blob/all-types/src/operator-typings.ts

@kwonoj
Copy link
Member

kwonoj commented Feb 2, 2016

#1086 is now checked in, those change can be used as reference to other operators as well.

@kwonoj kwonoj added priority: low TS Issues and PRs related purely to TypeScript issues labels Feb 2, 2016
@kwonoj
Copy link
Member

kwonoj commented Feb 6, 2016

Closing this issue via #1292.

@kwonoj kwonoj closed this as completed Feb 6, 2016
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
TS Issues and PRs related purely to TypeScript issues
Projects
None yet
Development

No branches or pull requests

3 participants