Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov.io compromise; secrets and access tokens have to be renewed #7237

Closed
8 tasks done
akarnokd opened this issue Apr 15, 2021 · 4 comments
Closed
8 tasks done

Codecov.io compromise; secrets and access tokens have to be renewed #7237

akarnokd opened this issue Apr 15, 2021 · 4 comments
Labels

Comments

@akarnokd
Copy link
Member

akarnokd commented Apr 15, 2021

I just received an email from Codecov.io converning their Bash script used for uploading coverage data. Apparently someone compromised their code between January and April which may have caused the leak of environmental secrets.

For us, this affects:

  • Javadoc upload personal access token,
  • Bintray key for uploading the snapshots,
  • Sonatype password,
  • The signing private key and its password.

The Javadoc upload is just a matter of regenerating the access token; already done that.

However, the rest is more of a trouble:

  • change the bintray and sonatype passwords; however, I don't know who else relied on those credentials in the ReactiveX organization,
  • create a completely new signing private key for RxJava; which I don't know how to do.

  • Change Javadoc upload access token
  • Change JFrog upload access token
  • Replace signing private key & password in GHA Secrets
  • Revoke previous signing private key
  • Change Sonatype password/access token
  • Clear build cache
  • Check snapshot still works
  • Check release still works
@akarnokd akarnokd added the Build label Apr 15, 2021
@akarnokd
Copy link
Member Author

akarnokd commented Apr 15, 2021

oss.jfrog.org

The snapshots go here. Unfortunately, I can't login with the credentials I know that would allow me to change the access key.

oss.sonatype.org

I can log in, but apparently it is setup to use LDAP authentication. I don't know how or where this LDAP is.

@benjchristensen please could you help with the whole issue?

@akarnokd
Copy link
Member Author

Okay, I changed the API key for oss.jfrog.org, but only through Bintray, which will go away. So not sure what will happen on May 1st.

@akarnokd
Copy link
Member Author

Update.
I generated a new private key for signing and changed the secrets accordingly. Also the snapshot release works with the new access token.

What's left is to generate a new sonatype access token, which I'm not sure I can do with my credentials. At worst, it would get a new token but I won't be able to see that token afterwards. Consequently, sonatype releases would be blocked until the right user (@benjchristensen ?) went in and extracted them. At least nobody with the old token would be able to do any rogue release of artifacts.

@akarnokd
Copy link
Member Author

Done.

All access tokens and the private key have been renewed. The release process succeeded as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant