Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single.concatEager is not implemented #5974

Closed
boris-petrov opened this issue Apr 25, 2018 · 9 comments
Closed

Single.concatEager is not implemented #5974

boris-petrov opened this issue Apr 25, 2018 · 9 comments

Comments

@boris-petrov
Copy link

Single.concatEager and Completable.concatEager are not available. Observable.concatEager and Maybe.concatEager are. Is there any reason for that or you just haven't gotten to that?

It's kind of a pain as I currently cast all my Singles to Maybes, use Maybe.concatEager and then cast back... :)

@akarnokd
Copy link
Member

How would Completable.concatEager work?

@boris-petrov
Copy link
Author

@akarnokd - well, I guess subscribe to all Completables at the same time and complete when all of them complete. I think the current Completable.concat subscribes to the Completables one after the other?

@akarnokd
Copy link
Member

There is already an operator for that specific behavior with Completables.

@boris-petrov
Copy link
Author

Ah, OK, sorry for the confusion then. But the Single.concatEager is missing indeed.

@akarnokd
Copy link
Member

PR welcome.

@Desislav-Petrov
Copy link
Contributor

Desislav-Petrov commented Apr 28, 2018

What should be the behaviour of the Single.concatEager - subscribe to all and push just the first value received ?

@akarnokd
Copy link
Member

It should match Maybe.concatEager.

@Desislav-Petrov
Copy link
Contributor

Ok.. i think i know what's going on - will try to submit a pull req for initial review tonight (please bear in mind it will be my first contrib :))

@akarnokd
Copy link
Member

Closing via #5976.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants