Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation error? #5782

Closed
RobLewis opened this issue Dec 28, 2017 · 2 comments
Closed

Documentation error? #5782

RobLewis opened this issue Dec 28, 2017 · 2 comments
Labels
1.x 2.x Documentation

Comments

@RobLewis
Copy link

What does this mean in the description of onTerminateDetach?

Returns:
an Observable which out references to the upstream producer and downstream Subscriber if the sequence is terminated or downstream unsubscribes

My guess: "nulls" belongs between "which" and "out"
@akarnokd
Copy link
Member

akarnokd commented Dec 28, 2017 •
edited
Loading

Yes, the word nulls out is missing there and also fromFlowable and Observable in v2. I'll post a fix to v2 and you are welcome to post a fix for v1 if you want.

@akarnokd akarnokd mentioned this issue Dec 28, 2017
Merged
@akarnokd
Copy link
Member

akarnokd commented Jan 2, 2018

Closing via #5783

@akarnokd akarnokd closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.x 2.x Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobLewis @akarnokd