Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(question) Is it right that rx.observables.BlockingObservable.last() returns null when the Observable is empty? #464

Closed
zsxwing opened this issue Nov 4, 2013 · 1 comment
Closed

(question) Is it right that rx.observables.BlockingObservable.last() returns null when the Observable is empty? #464

zsxwing opened this issue Nov 4, 2013 · 1 comment

Comments

@zsxwing
Copy link
Member

zsxwing commented Nov 4, 2013

Now rx.observables.BlockingObservable.last() returns null when the Observable is empty. However, null is a valid value in an Observable. So when last returns null, we can not make a distinction between these two situations. I think throwing an IndexOutOfBoundException is more reasonable.
@zsxwing zsxwing mentioned this issue Nov 7, 2013
Closed
@zsxwing zsxwing closed this as completed Nov 7, 2013
@zsxwing
Copy link
Member Author

zsxwing commented Nov 7, 2013

Have fixed in #470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zsxwing