-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.x: Base interface types #4420
Comments
|
Er, sorry I meant to change that paragraph before hitting create. I want to propose non-prefixed inner types similar to what This will only change non-stable APIs so they could just be renamed. I was suggesting The changes would look like this: |
Let's see a PR so the diff is more telling about the consequences. |
Can we do more about this or can this be closed? |
I think we're now at a good enough place with 1.x here. Any more changes would only be disruptive for the sake of being disruptive. |
Great! |
Before
Single
andCompletable
progress to stable, I'd like to address the interface naming inconsistency in a similar fashion to what #4044 did for 2.x.Here's the current state:
It's very clear that there's a lack of normalization.
I'd like to take the same approach as we did in 2.x and move to prefixes and top-level types.I'd like to normalize the names of the nested classes and make the subscribers top-level types. We can@Deprecate
the existing types and make them extend from these new top-level types to make migration easier, deleting these@Deprecated
types whenever these APIs turn stable. 👍 👎 ?Additionally, there's a problem with
CompletableSubscriber
in that it's an interface instead of an abstract class that also implementsSubscription
(as bothSubscriber
andSingleSubscriber
do). I would like to correct this. 👍 👎 ?The text was updated successfully, but these errors were encountered: