Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Completable.andThen(Completable) #3947

Closed
vanniktech opened this issue May 18, 2016 · 6 comments
Closed

Request: Completable.andThen(Completable) #3947

vanniktech opened this issue May 18, 2016 · 6 comments

Comments

@vanniktech
Copy link
Collaborator

To match Completable#andThen(Observable<T> next) and Completable#andThen(Single<T> next) it would be nice if there were an operator like this:

Completable#andThen(Completable next).

Unless there is some other way to achieve the same functionality right now.

@akarnokd
Copy link
Member

There is the endWith operator for this purpose, but you can post a PR renaming it.

@vanniktech
Copy link
Collaborator Author

@akarnokd thanks for the quick reply. Posted a PR for that. Just a quick question what about endWith(Observable<T> next) should that stay or should there also be andThen used?

@akarnokd
Copy link
Member

You can deprecate that as well.

@vanniktech
Copy link
Collaborator Author

Alright thanks. I updated the PR let me know whether I should squash commits and change commit message to match the new updated title or whether you'll use the GitHub squash and merge functionality.

@akarnokd
Copy link
Member

No need for squashing on your end.

@zsxwing
Copy link
Member

zsxwing commented May 23, 2016

Closing via #3948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants