Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix source maps by adding back sources and fixing path #2872

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

jasonaden
Copy link
Collaborator

We previously removed the /src directory to reduce the distributed output. However, this will break source maps as there are no sources to map to. Therefore we need to distribute one copy of the sources, thus putting back the /src directory.

Additionally, the path in the .js.map files was incorrect due to where /src lives in relation to the build outDir flag. This has been fixed.

@rxjs-bot
Copy link

Messages
📖

CJS: 1341.3KB, global: 739.6KB (gzipped: 138.7KB), min: 146.0KB (gzipped: 31.2KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.476% when pulling 0200917 on jasonaden:fix_source_maps into ba2f586 on ReactiveX:master.

@benlesh benlesh merged commit daaf424 into ReactiveX:master Sep 27, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants