Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(TestScheduler): return hot and cold observables #2305

Merged
merged 1 commit into from
Jan 29, 2017
Merged

refactor(TestScheduler): return hot and cold observables #2305

merged 1 commit into from
Jan 29, 2017

Conversation

mpodlasin
Copy link
Contributor

Description:

Return HotObservable and ColdObservable instead of simply Observable, in order to give users access to subscriptions parameter.

Motivation:

Previously getting subscriptions of observables for expectSubscriptions assertions was impossible without typecasting:

const hot = scheduler.createHotObservable('--a---b--|');
hot.subscriptions // does not compile

…eneric observable

Return HotObservable and ColdObservable instead of simply Observable, in order to give users access to subscriptions parameter
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.698% when pulling 79f2f9e on Podlas29:access-to-subscriptions into 31cf2bf on ReactiveX:master.

@kwonoj
Copy link
Member

kwonoj commented Jan 22, 2017

Looks good to me.

@benlesh benlesh merged commit 758aae9 into ReactiveX:master Jan 29, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants