Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using C# 7 pattern matching features #391

Merged
merged 2 commits into from
Apr 20, 2017
Merged

Conversation

bartdesmet
Copy link
Collaborator

Some trivial changes to use more C# 7.0 features.

@bartdesmet
Copy link
Collaborator Author

@onovotny @shiftkey - There seem to be build issues:

[00:01:59]      2>SourceLinkCreate:
[00:01:59]          unable to find repository origin with: dotnet sourcelink-git origin
[00:01:59]      2>Done Building Project "C:\projects\rx-net-la3iv\Rx.NET\Source\src\System.Reactive\System.Reactive.csproj" (default targets) -- FAILED.

Any thoughts what's off?

@shiftkey
Copy link
Contributor

@bartdesmet looks like something with the sourcelink setup

@clairernovotny
Copy link
Member

I just bumped sourcelink to version 2.1, lets see if that helps. Otherwise, we can loop in @ctaggart to help.

@clairernovotny
Copy link
Member

I've worked around this in dev by disabling sourcelink until @ctaggart can investigate further. Builds are green now.

@bartdesmet bartdesmet merged commit cabd3ca into develop Apr 20, 2017
@bartdesmet bartdesmet deleted the UseCSharp7Patterns branch April 20, 2017 17:58
@clairernovotny clairernovotny modified the milestone: 4.0 May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants