Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining Image features #278

Closed
rozele opened this issue Mar 22, 2016 · 4 comments
Closed

Fix remaining Image features #278

rozele opened this issue Mar 22, 2016 · 4 comments
Labels
.NET
Milestone
Core View Managers

Comments

@rozele
Copy link
Collaborator

rozele commented Mar 22, 2016 •
edited
Loading

The following Image features are not working in UIExplorer:

  • Resize Method
  • Tint Color
  • Background Color
  • Plain Static Image
@rozele rozele added p2 labels Mar 22, 2016
@rozele rozele added this to the UIExplorerApp milestone Mar 22, 2016
@rozele
Copy link
Collaborator Author

rozele commented Jun 7, 2016

And ImageSize

@ebragge ebragge self-assigned this Jun 7, 2016
ebragge added a commit that referenced this issue Jun 10, 2016
@ebragge
fix(ReactImageView): Add features
d1f4fde 
resizeMode
tintColor
backgroundColor
imageSize

Fixes #278, #366
@ebragge ebragge mentioned this issue Jun 10, 2016
Closed
ebragge added a commit that referenced this issue Jun 10, 2016
@ebragge
fix(RCTImageView): Add missing features
b1dec49 
- resizeMode
- tintColor
- backgroundColor
- imageSize

Fixes #278, #366
ebragge added a commit that referenced this issue Jun 11, 2016
@ebragge
fix(RCTImageView): Add missing features
9ab5467 
- resizeMode
- tintColor
- backgroundColor
- imageSize

Fixes #278, #366
ebragge added a commit that referenced this issue Jun 11, 2016
@ebragge
fix(RCTImageView): Add missing features
ae65f0a 
- resizeMode
- tintColor
- backgroundColor
- imageSize

Fixes #278, #366
ebragge added a commit that referenced this issue Jun 13, 2016
@ebragge
fix(RCTImageView): Add missing features
2f13658 
- resizeMode
- tintColor
- backgroundColor
- imageSize

Fixes #278, #366
@ebragge ebragge removed their assignment Aug 1, 2016
@Pokute
Copy link

Pokute commented Aug 8, 2016

It looks like this feature has been pretty close to finished, but it hasn't been merged into master yet.
I tried to merge it myself and the merge isn't clean (imagecache isn't used) but it implements the background and tintcolor features.

I need this feature within a couple of weeks and would like it in a master branch for minimal hassle. Is there any way I can help with this task, @ebragge, @rozele ?

@rozele rozele added the ready label Aug 8, 2016
@lznt
Copy link
Contributor

lznt commented Aug 15, 2016

Any idea when this might be moving to PR stage?

@phongcao phongcao self-assigned this Aug 19, 2016
@phongcao
Copy link
Member

And blurRadius also doesn't work.

@phongcao phongcao mentioned this issue Aug 22, 2017
Closed
@rozele rozele added the .NET label Feb 26, 2019
@chrisglein chrisglein added the .NET Archive Issue opened against deprecated .NET implementation, will be closed (label drives bot activity) label Oct 25, 2019
@ghost ghost removed the .NET Archive Issue opened against deprecated .NET implementation, will be closed (label drives bot activity) label Oct 26, 2019
@ghost ghost closed this as completed Oct 26, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.NET
Projects
None yet
Milestone
Core View Managers
Development

No branches or pull requests
6 participants
@rozele @lznt @Pokute @ebragge @phongcao @chrisglein