add support for an array of paths in <Route> and matchPath #5889
+146
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronswindle
force-pushed
the
path-array
branch
3 times, most recently
from
5654844 to
6bc2f8a
Compare
timdorr
force-pushed
the
master
branch
2 times, most recently
from
fb3a586 to
f9481bb
Compare
pshrmn
reviewed
Jan 27, 2018
This comment has been minimized.
This comment has been minimized.
timdorr
force-pushed
the
master
branch
4 times, most recently
from
8f33936 to
1fb8696
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Would also love to see this merged, definitely willing to help out if it needs any more work. |
This comment has been minimized.
This comment has been minimized.
|
Why wait for #5866 when this PR is already working? |
baronswindle
force-pushed
the
path-array
branch
from
7cd7864 to
92582d3
Compare
baronswindle
force-pushed
the
path-array
branch
from
92582d3 to
4b79b96
Compare
mjackson
approved these changes
Oct 15, 2018
There was a problem hiding this comment.
This looks great, thanks @baronswindle! And thank you for rebasing on top of all the changes from the past few weeks 😅
|
Just FYI everyone, this was just released in version 4.4.0-beta.4. You can try it out now by installing from the
|
|
Hey! That looks nice, but what about support of RegExp in paths?! react-route is still not fully same as it is in https://github.com/pillarjs/path-to-regexp, which supports RegExp |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I piggybacked off of the tests written for
matchPath()by @Shervanator at #5393, and I'm tackling the issue described by @mjackson at #5866.<Route>andmatchPath()match.pathis a stringI'm happy to add docs and examples if everybody is satisfied with the behavior. Let me know if you think any changes are in order as well.