Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix when the <Link> onClick invariant runs #3636

Merged
merged 1 commit into from
Jul 15, 2016
Merged

Fix when the <Link> onClick invariant runs #3636

merged 1 commit into from
Jul 15, 2016

Conversation

taion
Copy link
Contributor

@taion taion commented Jul 14, 2016

Fixes #3635

@taion
Copy link
Contributor Author

taion commented Jul 14, 2016

This also simplifies the logic around allowTransition a bit. If the default on the <Link> is prevented, we can just bail right away.

@taion
Copy link
Contributor Author

taion commented Jul 15, 2016

Anybody want to take a quick look? (:

@timdorr timdorr merged commit e706133 into master Jul 15, 2016
@timdorr
Copy link
Member

timdorr commented Jul 15, 2016

Sorry, I thought I merged this...

@timdorr timdorr deleted the fix-link-invariant branch July 15, 2016 20:25
@taion
Copy link
Contributor Author

taion commented Jul 15, 2016

999th merged PR!

Any objections if I cut a release now?

@taion
Copy link
Contributor Author

taion commented Jul 15, 2016

Closed, not merged. Darn. Much less impressive.

@timdorr
Copy link
Member

timdorr commented Jul 15, 2016

Nope, go for it.

@taion
Copy link
Contributor Author

taion commented Jul 18, 2016

Published on v2.6.0

@renovate renovate bot mentioned this pull request Oct 11, 2018
Closed
1 task
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taion @timdorr