Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining issues with #3556 #3561

Merged
merged 1 commit into from
Jun 21, 2016
Merged

Fix remaining issues with #3556 #3561

merged 1 commit into from
Jun 21, 2016

Conversation

taion
Copy link
Contributor

@taion taion commented Jun 21, 2016

cc @avanderhoorn: This is what I meant

@taion
Copy link
Contributor Author

taion commented Jun 21, 2016 •
edited
Loading

Specifically:

  1. Make similar APIs consistent
  2. Pick abstractions that maximize code reuse
  3. Leverage existing test cases when possible

@timdorr
Copy link
Member

timdorr commented Jun 21, 2016

LGTM.

@timdorr timdorr merged commit f9f5a88 into master Jun 21, 2016
@timdorr timdorr deleted the fix-3556 branch June 21, 2016 20:43
@taion
Copy link
Contributor Author

taion commented Jun 21, 2016

@timdorr wdyt of cutting 2.5.0 from this?

@timdorr
Copy link
Member

timdorr commented Jun 21, 2016

I say go for it. 👍

@taion
Copy link
Contributor Author

taion commented Jun 21, 2016

Okay – I'll hold off on releasing another v3 alpha though.

@taion taion mentioned this pull request Jun 22, 2016
Closed
@renovate renovate bot mentioned this pull request Oct 11, 2018
Closed
1 task
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taion @timdorr