Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add router to props for route components #3486

Merged
merged 1 commit into from
May 31, 2016
Merged

Add router to props for route components #3486

merged 1 commit into from
May 31, 2016

Conversation

jwbay
Copy link
Contributor

@jwbay jwbay commented May 20, 2016

Per discussion in #3325. It's a bit awkward to have to opt in to context or wrap route components in withRouter in order to do things like router.push considering all the other routing concerns already injected into route components.

If this can go in 2.x I can retarget there. I think the issue title threw me 😕

@taion
Copy link
Contributor

taion commented May 20, 2016

LGTM

@taion
Copy link
Contributor

taion commented May 20, 2016

3.x makes sense here, since all the other changes are on 3.x

@taion
Copy link
Contributor

taion commented May 31, 2016

Could I get another review here?

@timdorr
Copy link
Member

timdorr commented May 31, 2016

LGTM.

@timdorr timdorr merged commit 87d9b94 into remix-run:next May 31, 2016
@jwbay jwbay deleted the add-router-to-props branch June 1, 2016 04:17
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants