feat: web components | shadow dom - tooltip support #1039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbarion
changed the title
danielbarion
changed the title
danielbarion
commented
Jun 13, 2023
| @@ -8,7 +8,7 @@ import styles from './styles.module.css' | |||
|
|
|||
| function App() { | |||
| const [anchorId, setAnchorId] = useState('button') | |||
| const [isDarkOpen, setIsDarkOpen] = useState(false) | |||
| const [isDarkOpen, setIsDarkOpen] = useState(true) | |||
There was a problem hiding this comment.
I had to set the default state to open to have the access to the shadow dom element
| root.appendChild(style) | ||
| } | ||
| } | ||
| }) |
There was a problem hiding this comment.
I was not able to convert the CSS modules to text, so, I had to copy our current styles and export it as string to inject inside of shadow dom
There was a problem hiding this comment.
I'm able to do it on: #1041
| root.addEventListener(event, listener) | ||
| } else { | ||
| ref.current?.addEventListener(event, listener) | ||
| } |
There was a problem hiding this comment.
this is on WIP, but didn't worked yet
|
Try to update this PR as the following gets merged: #1041 |
|
I tried again but I was not able to make it work as expected on shadow DOM, so, I'll close this PR and we are accepting new PRs related to this issue. Thanks All! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1029
PS: I'm first trying to make it work, after that, we can refine the solution.