fix: Add missing footer to home page #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashirbadsahu
changed the title
KTibow
reviewed
Jan 4, 2024
src/layout/Hero/HeroImage.svelte
Outdated
| @@ -14,10 +14,10 @@ | |||
| } | |||
|
|
|||
| .hero-img { | |||
| overflow: hidden; | |||
| overflow:hidden; | |||
There was a problem hiding this comment.
Irrelevant change, incorrect formatting
There was a problem hiding this comment.
Ohh I did that by mistake, my bad. I have implemented the changes now:)
src/routes/+page.svelte
Outdated
| @@ -4,6 +4,7 @@ | |||
| import SocialHost from '$layout/Hero/SocialHost.svelte'; | |||
| import Wave from '$lib/components/Wave.svelte'; | |||
| import Head from '$lib/components/Head.svelte'; | |||
| import FooterHost from '$layout/Footer/FooterHost.svelte'; | |||
There was a problem hiding this comment.
I would suggest to group imports from layout with other imports from layout
There was a problem hiding this comment.
thanks for your advice. I'm implementing it.
Ushie
requested changes
Jan 4, 2024
|
I'll close this as there's currently no design decided, and this PR would no longer be fit for the design Nevertheless, thank you much for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #175
This PR addresses the issue of the missing footer on the home page of the website.
Changes Include:
Please review and provide any feedback.