Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube - Hide feed components): Hide 'Customize your feed' survey #4293

Open
3 tasks done
ILoveOpenSourceApplications opened this issue Jan 12, 2025 · 3 comments · Fixed by #4295 · May be fixed by #4280
Open
3 tasks done

feat(YouTube - Hide feed components): Hide 'Customize your feed' survey #4293

ILoveOpenSourceApplications opened this issue Jan 12, 2025 · 3 comments · Fixed by #4295 · May be fixed by #4280
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@ILoveOpenSourceApplications
Copy link
Contributor

ILoveOpenSourceApplications commented Jan 12, 2025

Feature description

Add an option to hide 'Customise your feed' banner. But maybe call it Hide feed survey for language reasons (due to customise/customize).

Teehee, I forgot we already have this option.

Image

Only feed_nudge.eml feed_nudge.eml & expandable_metadata.eml
Image (1264 x 244) Image (1264 x 201)

The gap between videos after hiding this banner is slightly big unless expandable metadata.eml is also added, And yes, I did have Hide expandable chip under videos on.

01-12 13:19:32.511 26009 26528 D revanced: LithoFilterPatch: Searching ID: null Path: video_lockup_with_attachment.eml|99d136b0777da665|CellType|video_lockup_attachments.eml|faaafa7fc7548d87|ContainerType|expandable_metadata.eml|240734a4fe42fc2b|inline_expansion.eml|2cb038dd091edb96|ContainerType|inline_expander.eml|c4e2f2ca4ea8f693|ContainerType| BufferStrings: inline_expansion_EhNBZndWRnNBTUE3ZzAuNDI4MzcxIIEBKAE%3D❙expansion_key_EhNBZndWRnNBTUE3ZzAuNDI4MzcxIIEBKAE%3D❙header_key_EhNBZndWRnNBTUE3ZzAuNDI4MzcxIIEBKAE%3D❙rotation_key_EhNBZndWRnNBTUE3ZzAuNDI4MzcxIIEBKAE%3D❙yt_outline_chevron_down_black_24❙expandable_metadata_header.eml|fb640af1f22d2de1❙&EhNBZndWRnNBTUE3ZzAuNDI4MzcxIIEBKAE%3D❙"2B0❙
01-12 13:19:32.511 26009 26528 D revanced: Filter: LayoutComponentsFilter Filtered path: video_lockup_with_attachment.eml|99d136b0777da665|CellType|video_lockup_attachments.eml|faaafa7fc7548d87|ContainerType|expandable_metadata.eml|240734a4fe42fc2b|inline_expansion.eml|2cb038dd091edb96|ContainerType|inline_expander.eml|c4e2f2ca4ea8f693|ContainerType|
01-12 13:19:33.023 26009 26530 D revanced: LithoFilterPatch: Searching ID: feed_nudge.eml|36f0079006dd08f2 Path: feed_nudge.eml|36f0079006dd08f2|CellType| BufferStrings: button.eml|713fd10bcb423d23❙Pick some videos to tell us what you like❙Roboto❙Customise your feed❙YouTubeSans-Bold❙icon_button.eml|13740bd07f6c2636

Motivation

The survey simply provides the user with a random selection of videos which may be completely useless and waste of space given that the user starts watching videos according to their own preferences.

Acknowledgements

  • I have checked all open and closed feature requests and this is not a duplicate
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Feature request Requesting a new feature that's not implemented yet label Jan 12, 2025
@ILoveOpenSourceApplications
Copy link
Contributor Author

Iirc, didn't we use expandable metadata.eml at first and was later changed to inline_expander.eml? If true, may I ask why this change was made?

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title feat(YouTube - Hide feed components): Hide feed survey feat(YouTube - Hide feed components): Hide 'Customize your feed' survey Jan 12, 2025
@LisoUseInAIKyrios
Copy link
Contributor

Maybe the fit blame will show a commit that mentions why.

The filter patterns could use more comments explaining what they are hiding, because it quickly turns into "What exactly does this hide? I don't know, better to leave it."

@LisoUseInAIKyrios
Copy link
Contributor

I think expandable meta data includes the video chapter previews in the search results, but I can't remember.

@LisoUseInAIKyrios LisoUseInAIKyrios linked a pull request Jan 18, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
2 participants