-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(YouTube - SponsorBlock): Button initialize failure, buttons do not show on some devices with custom roms #3945
Comments
Either the patch is missing an offset, or some A/B test is in play, making the patch hook a different object than expected. This needs further investigation to confirm. |
Is acidcitrus@a2fc1bc confirmed to fix the issue? The issue appears to be some devices or situations do not use RippleDrawable (https://imgur.com/8oegLdR), or it's an A/B test where the effect is turned off. You can try turning on incognito mode, resetting the app data, or logging into a different account and see if this also fixes it (if it is fixed, then it's definitely an A/B test). For the affected device, does the player settings button have this effect (gear icon beside the SB buttons)? If the effect is not present, then the SB buttons probably should not have the effect either. |
acidcitrus@a2fc1bc is not a confirmed fix. Incognito and different account don't help, so probably not A/B. Is that button test app yours and available to share? There does seem to be a ripple effect displaying in the settings button, as well as in other apps like the calculator. If I press the SB button, I receive a toast error. Logcat shows "revanced: SponsorBlockViewController toggleNewSegmentLayoutVisibility failure". Edit: Setting animations to 10x slower speed, I can definitely see ripple effects in YT player buttons. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unfortunately I'm not able to set up a development environment to build, but I should be able to patch with the CLI if provided with the .jar file. |
I'll try to add PR builds for patches so that we can test patches without having to clone and build locally |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thank you so much, SB buttons show properly and the toast errors are gone using these patches on the affected device. |
Bug description
Copied from thread I made in the official Discord:
Error logs
Solution
acidcitrus@a2fc1bc
Additional context
ReVanced official, DokeOS 4.0 - Android 13, YouTube 19.43.41, both GMSCore and root mount affected. Isolated to Blackview device, as my other 4+ Android devices from different OEMs have no issues running the same ReVanced patches (root & microG, A9-A15).
Acknowledgements
The text was updated successfully, but these errors were encountered: