Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Change header): Patch should be named "Custom header" and string improvements needed #2580

Closed
3 tasks done
KobeW50 opened this issue Jan 2, 2024 · 0 comments · Fixed by #2554
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Jan 2, 2024

Bug description

  1. The name Change header can be improved.

  2. The patch description should follow the wording pattern of similar patches (such as the Custom branding patch)

  3. The first two sentences of the patch options description are difficult to understand.

Error logs

No response

Solution

  1. The patch should be renamed to Custom header. This is more appropriate and better describes what it does.

  2. The patch description can be changed to Applies a custom header in the top left corner within the app. Defaults to the ReVanced header.

  3. The option description can be changed to Can be a header name or a path to a custom header folder to use in the top bar. A path to a folder must contain one or more of the following folders matching the DPI of your device: ...

Additional context

I can PR for this. Here is how the changes for 2 and 3 look:

image

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@KobeW50 KobeW50 added the Bug report Something isn't working label Jan 2, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios linked a pull request Jan 9, 2024 that will close this issue
1 task
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(Change header): Patch should be named "Custom header" and string improvements needed bug(YouTube - Change header): Patch should be named "Custom header" and string improvements needed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant