-
-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: be able to copy the recommended version #990
Comments
Hi, I would like to work on this issue. Can someone guide me where can i find the recommended version? where would the user have to click to be able to copy the recommended version with its name? Thank you. |
I feel like the best way of doing this is to add a screen when we click on a app which is not installed.
|
The version seems to be fetched via a PatcherApi. See the viewmodel: |
I think instead of copying, it could launch the browser. In this case, it should be accompanied by a "link" icon to signify an outgoing link. |
So should I try to add just a "link" icon or a whole screen as suggested by @wiiznokes ? @wiiznokes it might be better functionality wise to add a new screen, but im worried there is not much to put that will require a whole screen. what do you guys think? |
Next to the package name or version a "link" icon can be added to signify an outgoing link when the label is clicked on. |
@oSumAtrIX , sounds good. will try to implement this. could you help me finding the file where i will have to make this changes if possible? I'll also try to find it as well. Thank you! |
If we add a new screen, the list will be more "visible". |
No new screen is necessary. The label would open the browser on click. |
@AdiAr11 I do not know which file implements it. You can probably find it via a global string search. |
@oSumAtrIX No worries, I will find it. Thank you |
I just saw it has been implemented, nice works! |
Should be closed |
Type
Functionality
Issue
because it takes a long time to have to remember the right version and write it in a search engine.
Feature
be able to copy the recommended version with its name, example:
twitter apk version v9.71.0-release0
Motivation
because it simple to implement
Additional context
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: