-
-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Export button next to the Install button #886
Comments
Hey, I would like to work on this, can you please assign it to me? |
How would you achieve this? there are already 2 buttons (install and install as root) which is ideally the maximum amount of buttons |
@Ushie A popup can show the installation variants. The popup can be shown, when clicking on"Install". This would free the existing second button |
@Ushie will add a new button in the row inside the Visibility widget and will use sizedbox for the space. and will remove "Export APK" from the CustomPopupMenu. the rooted devices will see three buttons and non-root will see two Visibility( Visibility( |
I'm not sure if we're meant to go with as many as 3 buttons in a single row, let's see what Palm says |
@Ushie The new Installer screen design in the Figma somewhat already fixes that. Check it out. |
Looks good to me. However, I'm adding on to the proposal that we do not need to show the dialog to non-root users because they can't select any other installation types anyway. I'm thinking of a dialog with list items that have radio buttons. |
@PalmDevs I'd suggest to simply disable selecting the radio option for root installation. This will allow the user to know that a root installation is available instead of hiding it completely which then the user wouldn't know the option even exists. A "?" button or similar means can then explain why it is disabled. |
Type
Cosmetic
Issue
The export button is kinda hidden, and some people won't realize that it is an option.
Feature
Place the Export/Save APK button beside the Install button at the patch end-screen.
Motivation
Improved UX
Additional context
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: