Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Export button next to the Install button #886

Closed
4 tasks done
KobeW50 opened this issue May 23, 2023 · 9 comments · Fixed by #1062
Closed
4 tasks done

Move Export button next to the Install button #886

KobeW50 opened this issue May 23, 2023 · 9 comments · Fixed by #1062
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented May 23, 2023

Type

Cosmetic

Issue

The export button is kinda hidden, and some people won't realize that it is an option.

Feature

Place the Export/Save APK button beside the Install button at the patch end-screen.

Motivation

Improved UX

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager
@KobeW50 KobeW50 added the Feature request Requesting a new feature that's not implemented yet label May 23, 2023
@tejasbadone
Copy link

Hey, I would like to work on this, can you please assign it to me?

@Ushie
Copy link
Member

Ushie commented Jun 1, 2023

How would you achieve this? there are already 2 buttons (install and install as root) which is ideally the maximum amount of buttons

@oSumAtrIX
Copy link
Member

@Ushie A popup can show the installation variants. The popup can be shown, when clicking on"Install". This would free the existing second button

@tejasbadone
Copy link

tejasbadone commented Jun 1, 2023

@Ushie will add a new button in the row inside the Visibility widget and will use sizedbox for the space. and will remove "Export APK" from the CustomPopupMenu. the rooted devices will see three buttons and non-root will see two

Visibility(
visible: !model.isInstalled,
child: const SizedBox(
width: 16,
),
),

Visibility(
visible: !model.isInstalled,
child: CustomMaterialButton(
label: I18nText('installerView.exportApkMenuOption'),
isExpanded: true,
onPressed: () => model.exportResult(),
),
),

@Ushie
Copy link
Member

Ushie commented Jun 1, 2023

@Ushie A popup can show the installation variants. The popup can be shown, when clicking on"Install". This would free the existing second button

@PalmDevs Can you review this design proposal?

@Ushie
Copy link
Member

Ushie commented Jun 1, 2023

the rooted devices will see three buttons and non-root will see two

I'm not sure if we're meant to go with as many as 3 buttons in a single row, let's see what Palm says

@PalmDevs
Copy link
Member

PalmDevs commented Jun 1, 2023

How would you achieve this? there are already 2 buttons (install and install as root) which is ideally the maximum amount of buttons

@Ushie The new Installer screen design in the Figma somewhat already fixes that. Check it out.

@PalmDevs
Copy link
Member

PalmDevs commented Jun 1, 2023

@Ushie A popup can show the installation variants. The popup can be shown, when clicking on"Install". This would free the existing second button

@PalmDevs Can you review this design proposal?

Looks good to me. However, I'm adding on to the proposal that we do not need to show the dialog to non-root users because they can't select any other installation types anyway. I'm thinking of a dialog with list items that have radio buttons.

@oSumAtrIX
Copy link
Member

@PalmDevs I'd suggest to simply disable selecting the radio option for root installation. This will allow the user to know that a root installation is available instead of hiding it completely which then the user wouldn't know the option even exists. A "?" button or similar means can then explain why it is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants