Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a button to delete vanilla app after patching apk #604

Closed
3 of 4 tasks
Dr-Sauce opened this issue Dec 17, 2022 · 1 comment
Closed
3 of 4 tasks

feat: Add a button to delete vanilla app after patching apk #604

Dr-Sauce opened this issue Dec 17, 2022 · 1 comment
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@Dr-Sauce
Copy link

Dr-Sauce commented Dec 17, 2022

Type

Functionality

Issue

When you try to install the patched apk you get a warning because the vanilla app and the patched apk signature are different.

Feature

There's two ways to solve it.

  1. Show a button to delete the vanilla app if the vanilla app signature and patched apk signature conflicts.
    OR
  2. Add a delete vanilla app button in the 3 dots menu on the top right. (If the signature comparing process won't be added.)

image

Motivation

To improve users UX.

Currently users have to patch app -> go to home screen -> delete vanilla app -> come back to ReVanced Manager and press 'install'.

Additional context

Hello 🖐️

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • The issue is related solely to the ReVanced Manager
@Dr-Sauce Dr-Sauce added the Feature request Requesting a new feature that's not implemented yet label Dec 17, 2022
@Ushie
Copy link
Member

Ushie commented Jan 22, 2023

#494

@Ushie Ushie closed this as completed Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

2 participants