fix: Delete cached APK after patching #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of deleting the cached APK from the file picker **before** patching, the manager will only delete it **after** patching
|
Why this change? 👀 |
|
@kitadai31 There was an issue where if the user cancels patching and then re-patches, it wouldn't be able to re-copy the file as it had been already deleted. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 24, 2024
## [1.23.3-dev.1](v1.23.2...v1.23.3-dev.1) (2024-12-24) ### Bug Fixes * Delete cached APK only after successful patch ([#2331](#2331)) ([4ba7ec1](4ba7ec1))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of deleting the cached APK from the file picker before patching, the manager will now only delete it after patching.