feat: Import and export manager settings #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Instead of multiple import/export options show a dialog to select what(settings, patch selection) user wants to export would be clean way to do import/export |
Thank you for the suggestion. However, this is irrelevant to this PR. You can open a separate issue regarding it so that everyone can discuss it properly, and we can track the enhancement separately. This will also help keep the scope of this PR focused and ensure smoother reviews. |
oSumAtrIX
reviewed
Oct 22, 2024
assets/i18n/strings.i18n.json
Outdated
Comment on lines
201
to
206
| "exportManagerSettingsLabel": "Export manager settings", | ||
| "exportManagerSettingsHint": "Export manager settings to a JSON file", | ||
| "exportedManagerSettings": "Manager settings exported", | ||
| "importManagerSettingsLabel": "Import manager settings", | ||
| "importManagerSettingsHint": "Import manager settings from a JSON file", | ||
| "importedManagerSettings": "Manager settings imported", |
There was a problem hiding this comment.
Just saying "Export settings" is shorter. Adjust labels too.
oSumAtrIX
requested changes
Oct 22, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
# [1.23.0-dev.5](v1.23.0-dev.4...v1.23.0-dev.5) (2024-11-05) ### Features * Import and export manager settings ([#2268](#2268)) ([a45d959](a45d959))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 10, 2024
# [1.23.0](v1.22.0...v1.23.0) (2024-11-10) ### Bug Fixes * Don't show toasts when export cancelled ([#2230](#2230)) ([bd79496](bd79496)) * Fix the connectivity check toast again ([#2216](#2216)) ([a7e2281](a7e2281)) * Get changelogs for alternative sources ([#1766](#1766)) ([c729842](c729842)) * missing parameter in translations ([1c6c5d5](1c6c5d5)) * Resolve EACCESS error in special cases ([#2135](#2135)) ([1f95767](1f95767)) * Restore apk renaming during compile ([abdd9dc](abdd9dc)) ### Features * Also show new patches in the removed patches dialog ([#2257](#2257)) ([8872165](8872165)) * Import and export manager settings ([#2268](#2268)) ([a45d959](a45d959)) * Show changelogs from the latest to the last used patches version ([#2219](#2219)) ([daba737](daba737)) * Use ReVanced API v4 ([7b7d91d](7b7d91d)) ### Performance Improvements * Don't recalculate universal patches or compatible packages if not necessary ([7e3afe0](7e3afe0))
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Patch options and patched apps info are also included.
Let me know if those values shouldn't be included.