Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include supported architecture in APK search query #2042

Open
3 tasks done
KobeW50 opened this issue Jul 12, 2024 · 7 comments · Fixed by #2068 or #1857
Open
3 tasks done

feat: Include supported architecture in APK search query #2042

KobeW50 opened this issue Jul 12, 2024 · 7 comments · Fixed by #2068 or #1857
Assignees
Labels
Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Jul 12, 2024

Feature description

When tapping on the suggested version to start a search in a browser, the query should include the supported architecture of the device.

Example: com.google.android.apps.youtube.music apk version 7.03.52 arm64-v8a

If there are multiple architectures supported by the device, the Manager should only query for the most modern arch (arm64-v8a > armeabi-v7a, and x86_64 > x86).

Motivation

This will help users avoid choosing an APK that is not compatible with their device.

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • The feature request is only related to ReVanced Manager
@KobeW50 KobeW50 added the Feature request Requesting a new feature that's not implemented yet label Jul 12, 2024
@oSumAtrIX oSumAtrIX added ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager Depends on Downloader Issues that will no longer be applicable after the downloader is removed labels Jul 12, 2024
@Axelen123 Axelen123 removed ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager Depends on Downloader Issues that will no longer be applicable after the downloader is removed labels Jul 13, 2024
@oSumAtrIX oSumAtrIX added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Jul 13, 2024
@KobeW50
Copy link
Contributor Author

KobeW50 commented Jul 14, 2024

Btw, I intended this feature request for the current ReVanced Manager (I haven't tried the compose Manager). But if it is needed for compose Manager then sure

@oSumAtrIX oSumAtrIX removed the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Jul 14, 2024
@validcube
Copy link
Member

validcube commented Jul 14, 2024

Btw, I intended this feature request for the current ReVanced Manager (I haven't tried the compose Manager). But if it is needed for compose Manager then sure

👋 Hello, @KobeW50!

We have shifted focus to Compose variant of the ReVanced Manager, so your issue is delegated to said variant. Nonetheless thanks for the suggestion!

(That being said, Flutter variant will still be supported until Compose release, we could potentially backported the change to here too!)

For me I (personally) expect it to release later this year, so keep a eye out for pre-release/testing build. 👀

@validcube
Copy link
Member

👋 Hello @KobeW50!

Thanks for the feature request, this is added in ReVanced Manager Flutter v1.21.0; this issue will not be closed as it is now awaiting backport to Compose.

If the implementation of the feature wasn't up to your satisfaction, feels free to reopen!

@KobeW50

This comment has been minimized.

@validcube
Copy link
Member

Whoops, (It's almost 2 am, forgive me)

@validcube validcube reopened this Jul 29, 2024
@KobeW50

This comment has been minimized.

@validcube validcube added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Jul 31, 2024
@validcube
Copy link
Member

Anyone working on this? If not I'll pick this up this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
4 participants