Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve the language update settings #1837

Closed
3 tasks done
lamnhan066 opened this issue Apr 4, 2024 · 1 comment · Fixed by #1838
Closed
3 tasks done

feat: Improve the language update settings #1837

lamnhan066 opened this issue Apr 4, 2024 · 1 comment · Fixed by #1838
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@lamnhan066
Copy link
Contributor

Feature description

There is a TODO in this file:

// TODO(Someone): There must've been a better way to do this.

I can update this file to make it clearer and more readable.

You can take a look at this file and this diff to see how it will be implemented.

Here is the final look:

Screen.Recording.2024-04-04.at.12.56.53.mov

Motivation

As a package language_code maintainer, I can update the language_code and this file at the same time to make it consistent.

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • The feature request is only related to ReVanced Manager
@lamnhan066 lamnhan066 added the Feature request Requesting a new feature that's not implemented yet label Apr 4, 2024
@validcube validcube linked a pull request Apr 5, 2024 that will close this issue
@validcube
Copy link
Member

🥞 This issue have been closed as associated PR have been merged, feel free to reopen.

Usually GitHub would automatically close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants