Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Changelog includes pre-releases #1755

Closed
4 tasks done
oSumAtrIX opened this issue Mar 9, 2024 · 3 comments · Fixed by #1767 or #1763
Closed
4 tasks done

bug: Changelog includes pre-releases #1755

oSumAtrIX opened this issue Mar 9, 2024 · 3 comments · Fixed by #1767 or #1763
Assignees
Labels
Bug report Something isn't working

Comments

@oSumAtrIX
Copy link
Member

Bug description

The changelog includes pre-releases, as well as those, that are above your current version.

Version of ReVanced Manager and version & name of app you are patching

1.19.1

Installation method

None

ReVanced Manager logs

-

Patch logs

-

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The bug is only related to ReVanced Manager
@oSumAtrIX oSumAtrIX added the Bug report Something isn't working label Mar 9, 2024
@ILoveOpenSourceApplications

Is this still the case? I think with the latest release this isn't an issue anymore.

@oSumAtrIX
Copy link
Member Author

It should still be the case, in the current situation it doesn't occur though.

@TheAabedKhan
Copy link
Member

TheAabedKhan commented Mar 16, 2024

The changelog includes pre-releases

Should we not show pre-releases changelog if the current version is not a pre-release or add a toggle to include the pre-releases or not show them in any condition?

>as well as those, that are above your current version.

But changelog is supposed to show the changelog up to the latest version so that user can decide whether they want to update the manager, no?

Edit: Do you mean, the changelog that shows up as a "Changelog" sheet? I was talking about the changelog shown in the "Update" sheet.

Edit 2: I got it

@TheAabedKhan TheAabedKhan linked a pull request Mar 16, 2024 that will close this issue
@validcube validcube linked a pull request Mar 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
3 participants