-
-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Trim debug log output #1525
Comments
Every setting or patch option that has not been touched can be trimmed. Exceptions and everything that was touched should be included |
Couldn't this result in issues? Hypothetically there could be a patch that does require a value from the user for the patched app to function properly but does not throw an exception when fed the default value. |
No, if something is not included it is implicitly clear, that it's default |
SGTM |
Relying on implications within a debug log is not very helpful. This is meant for supporters who may simply have forgotten that some patch requires something else besides default options. |
Nothing that is default has to be included because it serves no purpose. Simply give an example if it were. |
What about the reddit patches -> missing client ID? |
Not possible. Either the user has not entered one (not included in log => its clear) or the user has entered one (its visible in the logs). To begin with, options like that are mandatory. You can not patch Reddit clients with the client spoof patch without entering a client id because it is marked as required. Any valid example? |
This is only the case if the supporter knows about this. As I've said above multiple times; But again,
I assume this is what you mean by the second part?
If so, Checklist can be adjusted |
I don't understand you. The example you give requires the user to enter an option. I asked for an example where not including defaults in the log is a problem |
What if the user doesn't do so? |
Then they can't proceed to patch. |
Okay so not an issue as I've mentioned above; Will adjust checklist |
Feature description
I'd suggest trimming any patch that has been included by default from log.
Anything that has been altered by the user should remain included.
Conceivably one might exclude all statements following the regex
.* succeeded
but this might go against attempts of removing hard-coded variables.Checklist
Motivation
After a while of seeing feat #1176 deployed, it has become apparent that the Discord message limit has become the main barrier for most users seeking support. The message limit is easily reached by the fact that Apps like YouTube have a lot of patches.
This surely does not affect all possibilities one might reach out for support, but it does hinder the main one.
tl;dr: To remove overall clutter and making it easier to share the logs.
Additional context
Original comment moved from #1176 ;
I'm not entirely sure if this is a feat or bug?
This could be extended to trim even more irrelevant information from the log as well, but isn't really needed.
Acknowledgements
The text was updated successfully, but these errors were encountered: