Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add if device is root/non-root to exported patch logs #1405

Closed
4 tasks done
KobeW50 opened this issue Oct 18, 2023 · 2 comments · Fixed by #1407 or #1399
Closed
4 tasks done

Add if device is root/non-root to exported patch logs #1405

KobeW50 opened this issue Oct 18, 2023 · 2 comments · Fixed by #1407 or #1399
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Oct 18, 2023

Feature description

Add a line to exported patch logs which will say if a device is rooted or not.

Motivation

It can be helpful when troubleshooting.

Additional context

Here is an example of how it would look:

~ Device Info
ReVanced Manager: 1.13.1
Build: release
Model: SM-S906U1
Android version: 13
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root: False

~ Patch Info
App: com.google.android.apps.youtube.music v6.21.51
...

Alternatively, the bool can be titled Environment:, and the responses can be either Root or Non-root. Here is what I mean:

~ Device Info
ReVanced Manager: 1.13.1
Build: release
Model: SM-S906U1
Android version: 13
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Environment: Non-root

~ Patch Info
App: com.google.android.apps.youtube.music v6.21.51
...

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The issue is solely related to the ReVanced Manager
@KobeW50 KobeW50 added the Feature request Requesting a new feature that's not implemented yet label Oct 18, 2023
@KobeW50 KobeW50 changed the title Add if device is rooted/non-root in exported patch logs Add if device is root/non-root in exported patch logs Oct 18, 2023
@KobeW50 KobeW50 changed the title Add if device is root/non-root in exported patch logs Add if device is root/non-root to exported patch logs Oct 18, 2023
@oSumAtrIX
Copy link
Member

Should say Root permissions: Yes/No

@validcube
Copy link
Member

🥞 The fix for this issue (#1407) has been released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
3 participants