fix: Empty “tmp-XXXXXX” directory keeps growing in cacheDir

Use a native getCodeCacheDir() for the optimizedDexDirectory
ReVanced · Sep 6, 2024 · 63e8720 · 63e8720
1 parent 921052a
commit 63e8720
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/android/app/src/main/kotlin/app/revanced/manager/flutter/MainActivity.kt b/android/app/src/main/kotlin/app/revanced/manager/flutter/MainActivity.kt
@@ -109,14 +109,13 @@ class MainActivity : FlutterActivity() {
 
                 "getPatches" -> {
                     val patchBundleFilePath = call.argument<String>("patchBundleFilePath")!!
-                    val cacheDirPath = call.argument<String>("cacheDirPath")!!
 
                     try {
                         val patchBundleFile = File(patchBundleFilePath)
                         patchBundleFile.setWritable(false)
                         patches = PatchBundleLoader.Dex(
                             patchBundleFile,
-                            optimizedDexDirectory = File(cacheDirPath)
+                            optimizedDexDirectory = codeCacheDir
                         )
                     } catch (ex: Exception) {
                         return@setMethodCallHandler result.notImplemented()

diff --git a/lib/services/manager_api.dart b/lib/services/manager_api.dart
@@ -427,19 +427,12 @@ class ManagerAPI {
       return patches;
     }
     final File? patchBundleFile = await downloadPatches();
-    final Directory appCache = await getTemporaryDirectory();
-    Directory('${appCache.path}/cache').createSync();
-    final Directory workDir =
-        Directory('${appCache.path}/cache').createTempSync('tmp-');
-    final Directory cacheDir = Directory('${workDir.path}/cache');
-    cacheDir.createSync();
     if (patchBundleFile != null) {
       try {
         final String patchesJson = await PatcherAPI.patcherChannel.invokeMethod(
           'getPatches',
           {
             'patchBundleFilePath': patchBundleFile.path,
-            'cacheDirPath': cacheDir.path,
           },
         );
         final List<dynamic> patchesJsonList = jsonDecode(patchesJson);