From 5c733932c7725c117758e96e56d6c01eb5d32737 Mon Sep 17 00:00:00 2001 From: Ushie Date: Thu, 7 Sep 2023 16:41:03 +0300 Subject: [PATCH] ci(pr-build): revert "sign apk with keystore (#1231)" This reverts commit 8bf08ff4641451db64c80fddc9a3281cdf73098b, as it fails for PRs originating from forks --- .github/workflows/pr-build.yml | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index 2d4127a4fd..0bb9bdb11f 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -37,26 +37,9 @@ jobs: - name: Build with Flutter env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - SIGNING_KEY_ALIAS: ${{ secrets.SIGNING_KEY_ALIAS }} - SIGNING_KEY_PASSWORD: ${{ secrets.SIGNING_KEY_PASSWORD }} - SIGNING_STORE_PASSWORD: ${{ secrets.SIGNING_KEYSTORE_PASSWORD }} run: flutter build apk --debug - - name: Sign APK - id: sign_apk - uses: ilharp/sign-android-release@v1 - with: - releaseDir: build/app/outputs/apk/debug - signingKey: ${{ secrets.SIGNING_KEYSTORE }} - keyStorePassword: ${{ secrets.SIGNING_KEYSTORE_PASSWORD }} - keyAlias: ${{ secrets.SIGNING_KEY_ALIAS }} - keyPassword: ${{ secrets.SIGNING_KEY_PASSWORD }} - - name: Get SHA short - id: vars - run: echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT - - name: Add version to APK - run: mv ${{ steps.sign_apk.outputs.signedFile }} revanced-manager-debug-${{ steps.vars.outputs.sha_short }}.apk - name: Upload build uses: actions/upload-artifact@v3 with: name: revanced-manager - path: revanced-manager-debug-${{ steps.vars.outputs.sha_short }}.apk + path: build/app/outputs/flutter-apk/app-debug.apk